fix(ci): unbreak workflow YAML and add a complete actions.lock - #4
Conversation
Remediates GitHub Workflow Dependency Locking (public preview), which rejects runs at startup_failure with zero jobs and no logs. See hyperpolymath/standards#657. Five steps, in order, because each blocks the next: 1. Unbroke any workflow whose `permissions:` carried a scalar with an indented mapping under it - blind-permissions-insertion damage. This matters beyond the one file: gh actions-lock refuses to run when ANY workflow in the repo fails to parse, so the repo could never acquire a lockfile and could never self-heal. 2. Repinned hyperpolymath/standards reusables off commits that have no actions.lock. The rejection requires the CALLEE to be covered at the pinned SHA, which is unsatisfiable at a pre-lockfile commit. 3. Generated the lockfile with gh actions-lock. 4. Hand-added the reusable-workflow caller entries the tool omits, as '<path>': []. Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile OMITS is rejected. A PARTIAL lock is worse than none - running gh actions-lock and stopping there is how this outage spread. 5. Restored SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps with head -1. Verified before push: 0 unparseable workflows, lockfile covers every workflow with no omissions, SPDX on line 1 in every file. Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0 startup_failure, 13 running. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request updates action version references across six GitHub Actions workflows. It adds ChangesWorkflow maintenance
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The pull request is not up to standards according to Codacy analysis. The most critical issue is the absence of the 'actions.lock' file from the diff, which is central to the PR's stated intent of implementing dependency locking. Additionally, the new 'workflow-linter.yml' enforces security standards (top-level permissions) that several workflows in this PR fail to meet. A logic error was also identified in the 'diagnostics' job, which lacks the necessary dependencies to access the build binary.
About this PR
- The 'actions.lock' file is missing from the pull request. This file is a central component of the intended dependency management system; its absence prevents verification of the manual overrides and the overall locking strategy.
2 comments outside of the diff
[REDACTED:HIGH_ENTROPY]
line 1🔴 HIGH RISK
Add a top-level 'permissions:' block (e.g., 'permissions: contents: read') to comply with the security standards enforced by the 'workflow-linter.yml' added in this PR.
line 148🟡 MEDIUM RISK
The 'diagnostics' job is missing a 'needs: build' requirement and an 'actions/download-artifact' step. Add these to ensure the binary is available for the check; otherwise, the job will fail to find the file and default to a fallback state.
Test suggestions
- Verify that the SPDX license header is located on the first line of all updated workflows.
- Confirm that the 'managed by gh actions-lock' banner is added consistently across workflows.
- Verify that actions/checkout and artifact-related actions are pinned to specific semantic tags (e.g., @v4.4.0).
- Confirm that the actions.lock file is present and contains the required manual overrides for callers.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Confirm that the actions.lock file is present and contains the required manual overrides for callers.
Low confidence findings
- The YAML mapping-scalar conflict mentioned in the PR description is not explicitly visible in the provided hunks. Please verify that the syntax fix was correctly staged and committed.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback




Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at
startup_failure— zero jobs, no logs, nothing in REST or GraphQL. Full analysis:hyperpolymath/standards#657.Proven on
hyperpolymath/anamnesis: 6 of 6 workflows dead → 0startup_failure, 13 running.Five steps, in order — each blocks the next
1. Unbreak the workflow YAML. Any
permissions:carrying a scalar with an indented mapping under it:This reaches past the one file:
gh actions-lockrefuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.2. Repin
standardsreusables off commits with noactions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.3. Generate the lockfile with
gh actions-lock.4. Hand-add the reusable-caller entries the tool omits, as
'<path>': [].P(startup_failure | has lockfile) = 91.7%vs15.8%without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Runninggh actions-lockand stopping there is how this outage spread.5. Restore
SPDX-License-Identifierto line 1, which the tool displaces with its own banner and which the workflow-security linter greps viahead -1.Verified before this PR was opened
0unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.🤖 Generated with Claude Code